Review main Merged

45994[TASK] Remove direct usage of DocumentTemplate::header

Georg Ringer CR +2 V +2 Easy +5 −16 updated 01/16/16, 12:05

Commit message

If ModuleTemplate is available, use its method 'header`
instead of the method of DocumentTemplate.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Morton Jonuschat +1
  • Verified V +2
    • Anja Leichsenring +2
    • Morton Jonuschat +1

Issues 1

Files 3

Review log 6

  1. Georg Ringer uploaded patch set 1 01/16/16, 10:04

  2. Markus Klein commented on patch set 1 01/16/16, 10:25

    SetupModuleController.php:340

    The $doc member can be removed completely, as it is unused now, right?
  3. Georg Ringer uploaded patch set 2 01/16/16, 10:36

  4. Morton Jonuschat voted on patch set 2 CR +1 V +1 01/16/16, 11:29

  5. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/16/16, 12:05

  6. Gerrit merged patch set 2 01/16/16, 12:05