Review main Merged

46020[TASK] Replace last occurrence of DocumentTemplate::getHeader

Georg Ringer CR +2 V +2 Easy +4 −1 updated 01/18/16, 04:12

Commit message

Replace the last occurrence with direct calls to the current API.

This place is well hidden in: Info module > Page TSConfig >
View TSConfig fields content.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Morton Jonuschat +1
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Morton Jonuschat +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 9

  1. Georg Ringer uploaded patch set 1 01/16/16, 16:27

  2. Morton Jonuschat voted on patch set 1 CR +1 V +1 01/16/16, 18:22

  3. Wouter Wolters voted on patch set 1 CR +1 01/16/16, 18:41

  4. Daniel Goerz voted on patch set 1 CR +1 V +1 01/16/16, 20:22

  5. Michael Oehlhof commented on patch set 1 CR +1 V -1 01/17/16, 00:23

    What about the missing icons for "Show record list" and "View webpage"?
  6. Georg Ringer commented on patch set 1 01/17/16, 20:14

    @Michael: all of those actions are available throught the click menu anyway, so no need to have those twice.
  7. Michael Oehlhof voted on patch set 1 V +1 01/17/16, 23:22

  8. Georg Ringer voted on patch set 1 CR +2 V +2 01/18/16, 04:12

  9. Gerrit merged patch set 1 01/18/16, 04:12