Review TYPO3_6-2 Merged

46158[BUGFIX] SimpleFileBackend::setCacheDirectory returns valid path name

Frank Nägler CR +2 V +2 Normal +90 −1 updated 01/22/16, 14:37

Commit message

The comment for the method
\TYPO3\CMS\Core\Cache\Backend\SimpleFileBackend::setCacheDirectory()
states clearly, that it is possible to provide an absolute path as
cache directory. However, in the lower part of the function, it is
stated, that if ($cacheDirectory0 == '/') the documentRoot should be
set to '/'. That results in a returned path like '//...'.
This causes problems within
\TYPO3\CMS\Core\Utility\GeneralUtility::validPathStr(), because pathes
with '//' in it are always invalid.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2