Review main Abandoned Breaking

46182[WIP][!!!][TASK] Move styles from _CSS_DEFAULT_STYLE into static template

Frank Nägler CR 0 V 0 Easy +7 −7 updated 04/08/16, 13:11

Commit message

Adding default styles by an extension is a bad style. An integrator should
decide to include it or not. The most integrator has to reset the default styles
for each extension, because the most integrator define there own CSS.

This patch move default CSS from _CSS_DEFAULT_STYLE into an external
CSS file and add a static template to optional include the default styles.

Review

  • Code review CR 0
  • Verified V 0

Files 4

Review log 4

  1. Frank Nägler uploaded patch set 1 01/23/16, 20:18

  2. Georg Ringer commented on patch set 1 01/24/16, 18:12

    setup.txt:1

    which will fail for all cases where the PAGE object is not called "page"...
  3. Frank Nägler commented on patch set 1 01/24/16, 18:47

    setup.txt:1 Reply

    agree, the patch is still WIP, because I am not sure about the concrete implementation. But the main idea and goal is clear: do not automatic include CSS which must be reset for each extension.
  4. Frank Nägler abandoned the change 04/08/16, 13:11

    will abandon this patch for now.