Review main Merged

46208[BUGFIX] Reallow custom request context in getUrl

Sascha Egerer CR +2 V +2 Easy +2 −7 updated 02/15/16, 12:14

Commit message

In b4813ddb55ab789ddd13e02234f147a44d2af1ed an patch
has been introduced which respects the default stream context
when requesting urls. But the change prevents that custom
stream options (headers) can be set.

The default stream context should be used and extended by the
given custom headers.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Claus Due +1
    • Ralf Merz +1
    • Stephan Großberndt +1
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1

Issues 2

Files 1

Review log 13

  1. Sascha Egerer uploaded patch set 1 01/24/16, 11:23

  2. Sascha Egerer wrote 01/24/16, 11:25

    Patch set 2: Commit message was updated.
  3. Stephan Großberndt voted on patch set 2 CR +1 01/24/16, 21:33

  4. Frank Nägler voted on patch set 2 CR +1 01/25/16, 16:00

  5. Frank Nägler voted on patch set 2 V +1 01/25/16, 16:03

  6. Claus Due voted on patch set 2 CR +1 01/31/16, 13:43

  7. Ralf Merz voted on patch set 2 CR +1 02/15/16, 10:39

  8. Andreas Kienast voted on patch set 2 CR +1 02/15/16, 10:42

  9. Sascha Egerer commented on patch set 2 02/15/16, 11:52

    Could anybody of you please verify this patch, please?
  10. Christian Kuhn commented on patch set 2 02/15/16, 12:10

    on it.
  11. Christian Kuhn voted on patch set 2 CR +2 V +2 02/15/16, 12:13

  12. Gerrit merged patch set 2 02/15/16, 12:13

  13. Christian Kuhn commented on patch set 3 02/15/16, 12:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit c706944fd1a4396141229ae4f44a3859ed58a1d2