Review main Merged

46245[BUGFIX] remove unnecessary htmlspecialchars

Marco Huber CR +2 V +2 Easy +5 −5 updated 01/28/16, 21:51

Commit message

The message is sent through htmlspecialchars in
TYPO3\CMS\Core\Messaging\FlashMessageQueue::renderFlashMessages(),
so we don't need it here.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1

Files 4

Review log 7

  1. Marco Huber uploaded patch set 1 01/26/16, 12:55

  2. Wouter Wolters voted on patch set 1 CR +1 01/26/16, 12:59

  3. Marco Huber commented on patch set 1 01/26/16, 13:06

    There are some more places, where the old FlashMessages::render() is used (see https://forge.typo3.org/issues/72438). When they get fixed, the htmlspecialchars should be removed, too. I will put a note in the ticket, too.
  4. Georg Ringer voted on patch set 1 CR +1 V +1 01/26/16, 20:04

  5. Wouter Wolters voted on patch set 1 CR +2 V +2 01/28/16, 21:51

  6. Gerrit merged patch set 1 01/28/16, 21:51

  7. Wouter Wolters commented on patch set 2 01/28/16, 21:51

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 8c0d0015ee62f19ad43fac65039ba430d0c38a6e