Review TYPO3_7-6 Abandoned

46262[BUGFIX] Avoid garbage upon failed import

Bernhard Kraft CR 0 V 0 Hard +315 −26 updated 06/14/17, 22:17

Commit message

When importing a large page structure any exception which could
possibly get thrown will result in an abort of the import. All
records which got inserted into the database until then could end up
on a wrong page, link to wrong elements, etc. as relations between
records are only updated after all records got inserted. The same is
true for an import which got aborted because of a PHP script timeout.

This bugfix resolves the problem by introduction DB transactions via
the DatabaseConnection class. In the case of a failed import all
statements are rolled back and newly created files will get removed.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5