4633[BUGFIX] Message about missing db credentials is misleading
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
-
Verified V +2
- Jigal van Hemert +2
Files 1
Review log 12
-
Christian Kuhn commented on patch set 1 08/28/11, 18:00
Christopher, would you like to push with your full name? -
Jigal van Hemert uploaded patch set 2 08/28/11, 18:00
-
Jigal van Hemert uploaded patch set 3 08/28/11, 18:00
-
Jigal van Hemert commented on patch set 3 V 0 08/28/11, 18:00
by team member; Looks good to me, approved Changed commit message. With vote for version 1 it can be merged. @Christopher: will you take care of earlier branches? -
Jigal van Hemert merged patch set 3 08/28/11, 18:00
-
Kestutis commented on patch set 1 08/28/11, 18:00
Verified; Looks good to me, but someone else must approve I successfully tested new class.tx_install.php file, then $TYPO3_CONF_VARS['SYS']['no_pconnect'] = 0; and got this error report: "(Database cannot be selected. Make sure that username, password and host are set correctly. If MySQL does not allow persistent connections, check that $TYPO3_CONF_VARS['SYS']['no_pconnect'] is set to "1".)" I also noticed then ['no_pconnect'] = 0, I clicked "User settings" and got this error: "Database Error: The current username, password or host was not accepted when the connection to the database was attempted to be established!" Although the probability is weak, that user will edit the localconf manually and will set "no_pconnect" to 0 after successful install, but a hint might be useful in this error report as well. -
Kestutis commented on patch set 2 08/28/11, 18:00
Hello, I successfully tested Patch set 2, and got "(Database cannot be selected. Make sure that username, password and host are set correctly. If MySQL does not allow persistent connections, check that $TYPO3_CONF_VARS['SYS']['no_pconnect'] is set to "1".)" message, when $TYPO3_CONF_VARS['SYS']['no_pconnect'] = 0; Regards, kestutis -
Kestutis commented on patch set 3 08/28/11, 18:00
Hello, I successfully tested Patch set 3, and got "(Database cannot be selected. Make sure that username, password and host are set correctly. If MySQL does not allow persistent connections, check that $TYPO3_CONF_VARS['SYS']['no_pconnect'] is set to "1".)" message, when $TYPO3_CONF_VARS['SYS']['no_pconnect'] = 0; Regards, Kestutis -
Mr. Jenkins commented on patch set 1 08/28/11, 18:00
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1734/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/28/11, 18:00
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1737/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/28/11, 18:00
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1738/ : SUCCESS -
Chris topher commented on patch set 3 08/28/11, 18:00
@ Kestutis: I like your idea, but I would rather add it to the text in the install tool, as this is, what people will read, when they decide to change or not to change the setting. I pushed that as Ifde0587bdc9bf554b5f8497c7aae05347349ba2e Have a look!