Review main Merged

4642[TASK] Improve description of $TYPO3_CONF_VARS['SYS']['no_pconnect']

Chris topher CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Improve the description of $TYPO3_CONF_VARS['SYS']['no_pconnect'],
so that people at least get a keyword, which they can put into
Google, when they don't know, what to set here.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Kestutis +1
  • Verified V +2
    • Christian Kuhn +2
    • Kestutis +1

Issues 1

Files 1

Review log 5

  1. Christian Kuhn commented on patch set 1 V 0 08/28/11, 23:00

    by team member; Looks good to me, approved
  2. Chris topher commented on patch set 1 08/28/11, 23:00

    I have not added such a hint, because then we would have to add it for many other propoerties as well. Basically the hoster could disable everything - but that is not really the target group of this ENTERPRISE(!) CMS. ;-)
  3. Kestutis commented on patch set 1 08/28/11, 23:00

    Verified; Looks good to me, but someone else must approve Having broader description and 'no_pconnect' => TRUE is good I think. Maybe just worth to add to Install tool description a warning like this - "Some hosting providers tend to disable pconnect for security reasons"..?
  4. Mr. Jenkins commented on patch set 1 08/28/11, 23:00

  5. Christian Kuhn merged patch set 1 08/28/11, 23:00