Review main Merged

46516[TASK] Format size in filelist info window

Daniel Maier CR +2 V +2 Easy +5 −0 updated 02/08/16, 09:49

Commit message

The file size information inside the filelist info window is now
formatted as bytes/kilobytes/megabytes instead of just showing the
plain integer value.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 12

  1. Daniel Maier uploaded patch set 1 02/07/16, 19:17

  2. Michael Oehlhof voted on patch set 1 CR +1 V +1 02/07/16, 22:10

  3. Andreas Kienast wrote 02/08/16, 07:14

    Patch set 2: Commit message was updated.
  4. Andreas Kienast commented on patch set 2 02/08/16, 07:15

    Sorry, but features won't get into released branches. So I removed "7.6" from the Releases line.
  5. Daniel Maier commented on patch set 2 02/08/16, 09:31

    Thanks for the hint. I've now also changed the corresponding forge issue accordingly.
  6. Frank Nägler commented on patch set 2 02/08/16, 09:41

    I suggest, this patch is not a feature, but a task. therefor no rst file is needed and the patch can go into 7.6 too.
  7. Frank Nägler wrote 02/08/16, 09:42

    Patch set 3: Published edit on patch set 2.
  8. Frank Nägler voted on patch set 3 CR +1 02/08/16, 09:42

  9. Frank Nägler voted on patch set 3 V +1 02/08/16, 09:44

  10. Andreas Kienast voted on patch set 3 CR +2 V +2 02/08/16, 09:45

  11. Gerrit merged patch set 3 02/08/16, 09:45

  12. Andreas Kienast commented on patch set 4 02/08/16, 09:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit ff8b912f0390da8e3dce11c07d95a70924575115