Review main Merged

46628[TASK] Remove FlexForm charset conversion

Benni Mack CR +2 V +2 Easy +2 −18 updated 02/12/16, 17:38

Commit message

There was a rare option before all DB code
was UTF-8 and BE was UTF-8, when
FlexForm XML was stored in a different charset.

The additional evaluation needs to be enabled
and was never enabled in the last versions.

The property is removed.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Jan Helke +1
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 02/12/16, 17:17

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 02/12/16, 17:29

  3. Christian Kuhn commented on patch set 1 CR 0 02/12/16, 17:32

    checking possible usage ... maybe we should add a .rst.
  4. Frank Nägler voted on patch set 1 CR +1 02/12/16, 17:37

  5. Christian Kuhn commented on patch set 1 CR +1 02/12/16, 17:37

    ter search showed that even no ter extension ever set this property. we'll remove this property without .rst file: even if someone sets it, it wouldn't harm and would just raise a notice level warning. we'll take this risk now and will not add a .rst file for this case to not pollute documentation with this rather useless information.
  6. Jan Helke voted on patch set 1 CR +1 02/12/16, 17:38

  7. Frank Nägler voted on patch set 1 CR +2 V +2 02/12/16, 17:38

  8. Gerrit merged patch set 1 02/12/16, 17:38