Review main Merged

46681[BUGFIX] Add missing new_content_element overrides in PageLayoutView

Richard Haeser CR +2 V +2 Easy +27 −7 updated 02/19/16, 17:30

Commit message

Add the missing override possibilities in PageLayoutView as introduced
by issue #70055. Also add check if the override attribute of
newContentElementWizard is set in the tsConfig array.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 1

Files 5

Review log 14

  1. Richard Haeser uploaded patch set 1 02/15/16, 19:58

  2. Wouter Wolters voted on patch set 1 CR +1 02/15/16, 20:20

  3. Helmut Hummel voted on patch set 1 CR +1 02/15/16, 20:24

  4. Markus Klein commented on patch set 1 02/15/16, 22:07

    PageLayoutView.php:533

    needs isset() or empty() check

    PageLayoutView.php:647

    same here

    PageLayoutView.php:1832

    and here
  5. Markus Klein wrote 02/15/16, 22:09

    Patch set 2: Published edit on patch set 1.
  6. Markus Klein wrote 02/15/16, 22:11

    Patch set 3: Published edit on patch set 2.
  7. Richard Haeser commented on patch set 3 02/16/16, 06:45

    I agree with the extra check if the. There are some other places where this should be checked. See https://review.typo3.org/#/c/43417/ where this check should be added too.
  8. Wouter Wolters commented on patch set 3 02/16/16, 23:04

    I agree that than the other places need to be fixed too.
  9. Richard Haeser uploaded patch set 4 02/19/16, 11:53

  10. Wouter Wolters voted on patch set 4 CR +1 02/19/16, 11:56

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 02/19/16, 17:26

  12. Frank Nägler voted on patch set 4 CR +2 V +2 02/19/16, 17:30

  13. Gerrit merged patch set 4 02/19/16, 17:30

  14. Frank Nägler commented on patch set 5 02/19/16, 17:30

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 20012755a1b7f1307e5fa6365cf1be6c39f3e4da