46683[!!!][TASK] Remove flashmessage_compatibility.js from core
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Daniel Goerz +1
- Andreas Kienast +1
-
Verified V +2
- Wouter Wolters +2
- Daniel Goerz +1
- Andreas Kienast +1
Issues 1
Files 3
Review log 10
-
Frank Nägler uploaded patch set 1 02/15/16, 20:05
-
Wouter Wolters commented on patch set 1 02/15/16, 20:12
Back when we deprecated this we made the decision to remove it in 9. We are in the beginning of 8. What is the reason to change this reasoning now? -
Andreas Kienast commented on patch set 1 02/16/16, 07:16
@Wouter: We have now the issue that the Severity AMD is never loaded, because of the singleton check. flashmessage_compatibility.js registers itself as "TYPO3.Severity" which now leads to issues. Please see this patch to clarify the issue I dealt with yesterday: https://review.typo3.org/#/c/46678/ -
Wouter Wolters commented on patch set 1 02/16/16, 07:46
That explains the reason but IMO that should be in the commit message. The commit message is now wrong because removal was schedule for v9. -
Andreas Kienast wrote 02/16/16, 09:35
Patch set 2: Commit message was updated. -
Andreas Kienast voted on patch set 2 CR +1 V +1 02/16/16, 09:35
-
Wouter Wolters voted on patch set 2 CR +1 V +1 02/16/16, 09:38
-
Daniel Goerz voted on patch set 2 CR +1 V +1 02/16/16, 09:39
-
Wouter Wolters voted on patch set 2 CR +2 V +2 02/16/16, 09:44
-
Gerrit merged patch set 2 02/16/16, 09:45