Review main Merged

46702[TASK] Move moduleLabels to ModuleLoader

Benni Mack CR +2 V +2 Hard +372 −103 updated 10/07/16, 14:01

Commit message

Already translated module labels were previously resolved
and stored within $GLOBALS[LANG]. Several checks
and calls were then made to ModuleLoader and $LANG.

All information about the module, as well as all labels
are now stored within ModuleLoader, a addLabelsForModule()
method and a getLabelsForModule() method are placed within
that method, where labels are stored (but not resolved
to the language yet). The language service then is only used
when outputting the labels in various places.

The method $LANG->addModuleLabels() and the public
property $LANG->moduleLabels were deprecated.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 11