Review main Merged

46715[BUGFIX] Improve accessibiity-check of index page in HMENU 'browse'

Markus Hölzle CR +2 V +2 Easy +1 −1 updated 02/26/16, 18:39

Commit message

The special HMENU 'browse' should check whether the page is
really accessible to avoid sql errors.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 13

  1. Markus Hölzle uploaded patch set 1 02/16/16, 14:20

  2. Wouter Wolters commented on patch set 1 02/16/16, 14:27

    Can you change the chmod of the file back to 644 ?
  3. Markus Hölzle uploaded patch set 2 02/16/16, 14:33

  4. Matthias Vogel voted on patch set 2 CR +1 V +1 02/16/16, 14:40

  5. Daniel Goerz commented on patch set 2 02/19/16, 17:44

    Please describe in your commit message what was changed in a meaningful way. Suggestion: Improve accessibiity-check of pages in HMENU
  6. Christian Kuhn commented on patch set 2 02/19/16, 18:15

    i don't really understand this. codewise, the change looks as if it basically just supresses a possible warning, i don't see how an sql error could evolve from this. could you elaborate a bit and maybe even provide a how-to-reproduce (a ts snipped and maybe a page-tree that is needed).
  7. Daniel Goerz uploaded patch set 3 02/19/16, 22:58

  8. Daniel Goerz uploaded patch set 4 02/19/16, 22:59

  9. Daniel Goerz commented on patch set 4 CR +1 V +1 02/19/16, 22:59

    Desription of how to repoduce in the ticket
  10. Frank Nägler voted on patch set 4 CR +1 02/26/16, 18:37

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 02/26/16, 18:37

  12. Gerrit merged patch set 4 02/26/16, 18:39

  13. Christian Kuhn commented on patch set 5 02/26/16, 18:39

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 276f2ff9d8b8286ec1b5ed07ac3b2b32fb8e726d