Review main Abandoned

46758[BUGFIX] Use HttpRequest inside getUrl to have correct HTTP settings

Albrecht Köhnlein CR 0 V 0 Easy +9 −9 updated 12/07/16, 14:53

Commit message

Replaced "file_get_content()" inside GeneralUtility::getUrl by
TYPO3\CMS\Core\Http\HttpRequest. It's only a proposal and not a finished
solution. The $includeHeader part with fsockopen is not done at all. And
I don't know how local files are handled inside getUrl(), so I don't know
if this could be a conflict. But it works for my case in Extension Manager
behind a proxy and without CURL installed on the server.
And I only tested it on TYPO3 6.2, but I think it's the same here in the
master. Even if the code differs in TYPO3 7. But I'm sure there would be
a way to bring it to old LTS in Git.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1