Review main Merged

46880[BUGFIX] Convert colPos in backend layout wizard to number

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 02/25/16, 16:35

Commit message

The method `setColumn` in the backend layout wizard sanitizes the
value by wrapping it into a <p> tag and fetching its text which strips
off any HTML. This returns a string.

However, the code later checks after performing a save action whether
the value is a number. The value gets converted to a number in
`setColumn` to recover the functionality.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1