Review main Merged

47026[FEATURE] Allow Backend Logo to be set via extConf

Benni Mack CR +2 V +2 Easy +30 −6 updated 03/04/16, 09:24

Commit message

The Backend Logo can now be configured via extConf
and the Extension Manager.

The $GLOBALS[TBE_STYLES][logo] option has no effect
anymore.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Wouter Wolters +1
    • Morton Jonuschat +1
  • Verified V +2
    • Benjamin Kott +2
    • Morton Jonuschat +1

Issues 1

Files 4

Review log 13

  1. Benni Mack uploaded patch set 1 03/03/16, 21:05

  2. Georg Ringer commented on patch set 1 03/04/16, 06:33

    Feature-74109-SetTheAlternativeBackendLogoViaExtensionManager.rst:8

    we switched the logo from left to right?
  3. Mathias Brodala commented on patch set 1 03/04/16, 09:03

    Feature-74109-SetTheAlternativeBackendLogoViaExtensionManager.rst:8

    Can we mention the exact configuration option here? Some people might want to set this with a site extension or similar instead of graphically. ;-)
  4. Mathias Brodala commented on patch set 1 CR -1 03/04/16, 09:04

    BackendController.php:267

    Please use $extConf['backendLogo'] ?? 'EXT...' to avoid a notice.
  5. Benni Mack wrote 03/04/16, 09:06

    Patch set 2: Published edit on patch set 1.
  6. Benni Mack wrote 03/04/16, 09:07

    Patch set 3: Published edit on patch set 2.
  7. Benjamin Kott voted on patch set 3 CR +2 V +2 03/04/16, 09:09

  8. Wouter Wolters voted on patch set 3 CR +1 03/04/16, 09:10

  9. Mathias Brodala commented on patch set 3 03/04/16, 09:11

    It's not really breaking but people will wonder about this, so maybe add an important RST for this?
  10. Benni Mack commented on patch set 3 03/04/16, 09:14

    well, that's why I added a Feature.RST, which contains the "Impact" section, IMHO that should be sufficient.
  11. Morton Jonuschat voted on patch set 3 CR +1 V +1 03/04/16, 09:18

  12. Gerrit merged patch set 3 03/04/16, 09:20

  13. Mathias Brodala commented on patch set 4 03/04/16, 09:24

    > well, that's why I added a Feature.RST, which contains the "Impact" > section, IMHO that should be sufficient. OK then.