Review main Merged

47042[FOLLOWUP][FEATURE] Allow Backend Logo to be set via extConf

Benni Mack CR +2 V +2 Easy +12 −3 updated 03/04/16, 13:40

Commit message

The new PHP 7 syntax introduced also returns an empty
string, if set but empty.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1

Issues 1

Files 2

Review log 9

  1. Benni Mack uploaded patch set 1 03/04/16, 11:20

  2. Benni Mack uploaded patch set 2 03/04/16, 11:43

  3. Björn Jacob commented on patch set 1 V -1 03/04/16, 11:43

    Works fine with something like EXT:theme/Resources/Public/Images/Backend/logo.png but not with "//domain.tld/login-logo.png)".
  4. Björn Jacob commented on patch set 2 03/04/16, 12:10

    I'm on it. I'm changing a translation. Discussed with Benni.
  5. Björn Jacob uploaded patch set 3 03/04/16, 13:29

  6. Björn Jacob uploaded patch set 4 03/04/16, 13:32

  7. Björn Jacob voted on patch set 4 CR +1 V +1 03/04/16, 13:32

  8. Christian Kuhn voted on patch set 4 CR +2 V +2 03/04/16, 13:40

  9. Gerrit merged patch set 4 03/04/16, 13:40