Review main Merged

47263[BUGFIX] Make preview of translated pages possible

Heiko Hardt CR +2 V +2 Easy +3 −1 updated 03/18/16, 10:00

Commit message

This fix solves the problem that hidden page translations not are not
reviewable if logged in and "Show hidden pages" in admin panel is
enabled.

Treat records of "pages_language_overlay" as pages to make use of
the showHiddenPage flag.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 15

  1. Heiko Hardt uploaded patch set 1 03/14/16, 21:49

  2. Markus Klein commented on patch set 2 03/14/16, 21:56

    Published edit on patch set 1.
  3. Markus Klein voted on patch set 2 CR +1 03/14/16, 21:57

  4. Mathias Schreiber voted on patch set 2 CR +1 V +1 03/15/16, 12:38

  5. Andreas Kienast commented on patch set 2 03/15/16, 13:59

    I don't understand how I can test the patch. I can preview a page with a hidden pages_language_overlay record, although the preview stays in the original language. This behavior doesn't change after applying the patch.
  6. Mathias Schreiber commented on patch set 2 03/15/16, 14:01

    did you set the TSConfig for preview Languages?
  7. Andreas Kienast commented on patch set 2 03/15/16, 14:02

    I missed that information, thanks
  8. Andreas Kienast updated the commit message in patch set 3 03/15/16, 17:00

  9. Andreas Kienast voted on patch set 3 CR +1 V +1 03/15/16, 17:00

  10. Frank Nägler commented on patch set 3 CR +1 03/16/16, 16:54

    PageRepository.php:1129

    it is time to get rid of this table :)
  11. Andreas Kienast commented on patch set 3 03/18/16, 08:41

    I needed to enable "Show hidden pages" in the admin panel to be able to test this patch.
  12. Mathias Schreiber voted on patch set 3 CR +1 V +1 03/18/16, 09:50

  13. Andreas Kienast voted on patch set 3 CR +2 V +2 03/18/16, 10:00

  14. Gerrit merged patch set 3 03/18/16, 10:00

  15. Andreas Kienast commented on patch set 4 03/18/16, 10:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 6f117f8c2386f6a7e0362d317ca26baa19761fe4