Review main Merged

47309[TASK] Use file_get_contents instead of getUrl()

Benni Mack CR +2 V +2 Normal +78 −68 updated 03/29/16, 05:24

Commit message

The method GeneralUtility::getUrl() is used a lot in the
core where only local files are allowed.

Most occurrences can be replaced by using the native
file_get_contents() PHP function.

file_get_contents() is now always used when

* is_file() is called
* only local paths (e.g. prefixed with PATH_site)
* absolute paths (GeneralUtility::getFileAbsFileName)
* ensured that files within extensions

are checked before. In these cases getUrl() MUST NOT BE
USED but built-in file_get_contents() must be used instead.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 30

Show 10 more files