Review main Merged

47371[BUGFIX] Use `modTSconfig` for default language label, if set

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 03/23/16, 19:29

Commit message

Due to a wrong assignment, modSharedTSconfig is always used
to set the default language label in PageLayoutController, even if
modTSconfig is set.

modTSconfig is now used if possible.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Mathias Schreiber +1
    • Alexander Opitz +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Mathias Schreiber +1
    • Alexander Opitz +1

Issues 1

Files 1

Review log 9

  1. Andreas Kienast uploaded patch set 1 03/23/16, 18:06

  2. Wouter Wolters voted on patch set 1 CR +1 03/23/16, 18:08

  3. Daniel Goerz commented on patch set 1 03/23/16, 18:16

    PageLayoutController.php:406

    Actually this could be omitted completely. Elvis Operator would do the job.
  4. Alexander Opitz voted on patch set 1 CR +1 V +1 03/23/16, 18:17

  5. Mathias Schreiber commented on patch set 1 CR +1 V +1 03/23/16, 18:29

    PageLayoutController.php:406 Reply

    on 6.2 and 7.6? Backport error is too risky in my eyes.
  6. Daniel Goerz voted on patch set 1 CR +1 V +1 03/23/16, 19:13

  7. Wouter Wolters voted on patch set 1 CR +2 V +2 03/23/16, 19:28

  8. Gerrit merged patch set 1 03/23/16, 19:28

  9. Wouter Wolters commented on patch set 2 03/23/16, 19:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f542a43dcbf140952b5997828cbea94731a79170