Review TYPO3_7-6 Merged

47422[TASK] ResourceStorage->addFile() should not delete orig file if requested

Christian Kuhn CR +2 V +2 Easy +3 −2 updated 03/30/16, 11:09

Commit message

FALs ResourceStorage->addFile() is the main method to populate a locale
file into a FAL storage. Internally, the method calls the assigned and
protected driver of this storage and calls addFile() on the
driver after checking permissions.
The method *always* deletes the local original file after it has been
added to the storage. This is funny, since addFile() should then call
moveFile(), but moveFile() exists and is only thought to move
files between storages and not from non-storage to storage.
The drivers addFile() however already contains an argument that
suppresses the deletion of the original file, but that argument is
not added to addFile() of the storage ...
The patch now adds this argument to the method signature of
ResourceStorage addFile() to mitigate the issue in a fully
backwards compatible way.
Since the patch is non-destructive and low-risk, the
patch is requested for 7.6, too.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1