Review main Merged Breaking

47481[!!!][TASK] Remove FlexForm options in DefaultConfiguration

Benni Mack CR +2 V +2 Easy +37 −6 updated 04/01/16, 10:34

Commit message

There are several options regarding flexforms which
are unneeded nowadays.

$TYPO3_CONF_VARS[BE][niceFlexFormXMLtags]
$TYPO3_CONF_VARS[BE][compactFlexFormXML]

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2
    • Morton Jonuschat +2
    • Christian Kuhn +1

Issues 1

Files 4

Review log 20

  1. Benni Mack uploaded patch set 1 04/01/16, 09:23

  2. Christian Kuhn commented on patch set 1 04/01/16, 09:29

    lets handle niceFlexFormXMLtag and compactFlexFormXML with one patch and sort out the cdata thing with a second patch.
  3. Morton Jonuschat commented on patch set 1 CR +1 V +1 04/01/16, 10:01

    Unit Test, Functionals and Flexforms in the Backend OK
  4. Morton Jonuschat voted on patch set 1 CR 0 04/01/16, 10:01

  5. Benni Mack uploaded patch set 2 04/01/16, 10:05

  6. Morton Jonuschat commented on patch set 3 04/01/16, 10:08

    Published edit on patch set 2.
  7. Morton Jonuschat voted on patch set 3 CR +1 V +1 04/01/16, 10:09

  8. Christian Kuhn commented on patch set 3 04/01/16, 10:12

    on it.
  9. Oliver Hader commented on patch set 3 CR -1 04/01/16, 10:16

    We shout keep CDATA since that's the way to store markup as content... Otherwise we might face problems in that regard

    DefaultConfiguration.php:1048

    I'd rather keep the CDATA part since that's the way to store markup as content instead of treating it as additional nodes

    DefaultConfiguration.php:1048

    I'd rather keep CDATA

    DefaultConfiguration.php:1048

    I'd rather keep CDATA
  10. Markus Klein commented on patch set 3 04/01/16, 10:16

    word missing or "more simple"?
  11. Benni Mack commented on patch set 3 04/01/16, 10:17

    DefaultConfiguration.php:1048 Reply

    Please check the code again. I move from "0" to "false" to have it a proper boolean.
  12. Benni Mack updated the commit message in patch set 4 04/01/16, 10:18

  13. Oliver Hader commented on patch set 4 04/01/16, 10:20

    DefaultConfiguration.php:1048 Reply

    A right... then I'd opt for changing this to true

    DefaultConfiguration.php:1048

    Argh... Then I'd opt to use true here - which might go to a separate patch set as well
  14. Christian Kuhn commented on patch set 4 04/01/16, 10:23

    Reply

    Done

    DefaultConfiguration.php:1048 Reply

    ok, we move this change out of this patch.
  15. Christian Kuhn uploaded patch set 5 04/01/16, 10:24

  16. Christian Kuhn voted on patch set 5 CR +1 V +1 04/01/16, 10:29

  17. Morton Jonuschat voted on patch set 5 CR +1 V +1 04/01/16, 10:29

  18. Oliver Hader commented on patch set 5 CR +1 04/01/16, 10:31

    Forget my remarks about CDATA - I mixed things here...
  19. Morton Jonuschat voted on patch set 5 CR +2 V +2 04/01/16, 10:34

  20. Gerrit merged patch set 5 04/01/16, 10:34