47481[!!!][TASK] Remove FlexForm options in DefaultConfiguration
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2
- Morton Jonuschat +2
- Christian Kuhn +1
Issues 1
Files 4
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −3
- typo3/sysext/core/Configuration/DefaultConfiguration.php7+1 −3
- typo3/sysext/core/Documentation/Changelog/master/Breaking-75355-FlexForm-relatedOptionsRemoved.rstnew+32 −0
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+3 −0
Review log 20
-
Benni Mack uploaded patch set 1 04/01/16, 09:23
-
Christian Kuhn commented on patch set 1 04/01/16, 09:29
lets handle niceFlexFormXMLtag and compactFlexFormXML with one patch and sort out the cdata thing with a second patch. -
Morton Jonuschat commented on patch set 1 CR +1 V +1 04/01/16, 10:01
Unit Test, Functionals and Flexforms in the Backend OK -
Morton Jonuschat voted on patch set 1 CR 0 04/01/16, 10:01
-
Benni Mack uploaded patch set 2 04/01/16, 10:05
-
Morton Jonuschat commented on patch set 3 04/01/16, 10:08
Published edit on patch set 2. -
Morton Jonuschat voted on patch set 3 CR +1 V +1 04/01/16, 10:09
-
Christian Kuhn commented on patch set 3 04/01/16, 10:12
on it. -
Oliver Hader commented on patch set 3 CR -1 04/01/16, 10:16
We shout keep CDATA since that's the way to store markup as content... Otherwise we might face problems in that regardDefaultConfiguration.php:1048I'd rather keep the CDATA part since that's the way to store markup as content instead of treating it as additional nodesDefaultConfiguration.php:1048I'd rather keep CDATADefaultConfiguration.php:1048I'd rather keep CDATA -
Markus Klein commented on patch set 3 04/01/16, 10:16
word missing or "more simple"? -
Benni Mack commented on patch set 3 04/01/16, 10:17
DefaultConfiguration.php:1048ReplyPlease check the code again. I move from "0" to "false" to have it a proper boolean. -
Benni Mack updated the commit message in patch set 4 04/01/16, 10:18
-
Oliver Hader commented on patch set 4 04/01/16, 10:20
DefaultConfiguration.php:1048ReplyA right... then I'd opt for changing this to trueDefaultConfiguration.php:1048Argh... Then I'd opt to use true here - which might go to a separate patch set as well -
Christian Kuhn commented on patch set 4 04/01/16, 10:23
Reply
DoneDefaultConfiguration.php:1048Replyok, we move this change out of this patch. -
Christian Kuhn uploaded patch set 5 04/01/16, 10:24
-
Christian Kuhn voted on patch set 5 CR +1 V +1 04/01/16, 10:29
-
Morton Jonuschat voted on patch set 5 CR +1 V +1 04/01/16, 10:29
-
Oliver Hader commented on patch set 5 CR +1 04/01/16, 10:31
Forget my remarks about CDATA - I mixed things here... -
Morton Jonuschat voted on patch set 5 CR +2 V +2 04/01/16, 10:34
-
Gerrit merged patch set 5 04/01/16, 10:34