Review main Merged

47502[TASK] Clean up unit tests on Windows

Susi Moog CR +2 V +2 Normal +44 −96 updated 04/07/16, 15:35

Commit message

At the moment a lot of tests are skipped on Windows environments.
The main reasons are permissions, symlinks and shell exec commands.
As symlinks are now working on Windows (if the user / group is allowed
to create them) there is no reason to skip those tests. As you can only
create valid symlinks on Windows (the target is checked for existence)
the tests needed to be adjusted to take that into account.

Additionally some of the other tests don't need to be skipped either, as
they mock all system specific calls (e.g. AbstractNodeTests).

For the other tests the message on skipping was updated to contain more
information as to what causes them to be irrelevant on Windows.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 10