Review main Merged

47549[BUGFIX] User proper Fluid namespace detection

Gianluigi Martino CR +2 V +2 Nightmare +4632 −8 updated 04/13/16, 08:01

Commit message

The Fluid namespaces can be put in short-syntax, and in tags to be
resolved. However, if the template source is very large, then
preg_match_all() stops and returns "0" although the matched values are
within $matches. However, the $matched result is "0".

The regular expression for doing so, is very exhaustive and greedy, and
uses preg_match_all() however, preg_match() does the job as well.

Additionally, the regular expression is changed to be less
greedy (using *?).

An example where this is necessary is the FileList search module where
the additional namespaces are not resolved currently and the core icons
are not shown, because of the memory - exhausting regular expression.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4