Review main Merged

47647[TASK] Route phantomjs through selenium again

Christian Kuhn CR +2 V +2 Easy +4 −2 updated 04/13/16, 15:24

Commit message

There is some weird issue in the PHP internal web server
resulting in unexpected EOF in combination with phantomjs.
Having selenium in between seems to solve the issue for now.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sascha Egerer +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Sascha Egerer +1
    • Susi Moog +1

Issues 1

Files 2

Review log 7

  1. Christian Kuhn uploaded patch set 1 04/13/16, 15:09

  2. Christian Kuhn commented on patch set 1 04/13/16, 15:09

  3. Susi Moog voted on patch set 1 CR +1 V +1 04/13/16, 15:10

  4. Sascha Egerer commented on patch set 1 CR -1 04/13/16, 15:12

    Currently testing
  5. Sascha Egerer commented on patch set 1 CR +1 V +1 04/13/16, 15:23

    works if phantomJs is installed locally
  6. Christian Kuhn voted on patch set 1 CR +2 V +2 04/13/16, 15:24

  7. Gerrit merged patch set 1 04/13/16, 15:24