Review main Abandoned

47664[WIP][TASK] Streamline page not found actions in TSFE

Benni Mack CR 0 V 0 Normal +132 −70 updated 10/20/17, 14:12

Commit message

When a page is not found or inaccessible there are a lot of methods
within TSFE and a lot of duplicated code which can be simplified.

New methods are introduced:
$TSFE->pageNotFoundAction()
$TSFE->unavailablePageAction()

that throw Exceptions, display error messages or just log the information
into GeneralUtility::sysLog() depending on the settings.

All other existing places just call these methods.

The following methods are therefore deprecated:
* pageUnavailableAndExit()
* pageNotFoundAndExit()
* checkPageUnavailableHandler()
* pageUnavailableHandler()
* pageNotFoundHandler()

Further cleanup (separate patch) is to extract the Page Not Found logic into a separate controller.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3