Review main Merged

47669[TASK] Deprecate GeneralUtility methods

Benni Mack CR +2 V +2 Normal +94 −32 updated 04/19/16, 19:25

Commit message

There are some methods within GeneralUtility that are not used within
TYPO3 anymore or a now just plain stubs for PHP methods.

Additionally, there are some parameters within wrapJS() that have no
effect at all, and are removed without substitution.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1

Issues 1

Files 6

Review log 26

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 04/14/16, 15:07

  1. Benni Mack uploaded patch set 2 04/14/16, 15:16

  2. Benni Mack uploaded patch set 3 04/14/16, 15:32

  3. Wouter Wolters commented on patch set 3 04/14/16, 19:29

    GeneralUtility.php:934

    missing @deprecated
  4. Wouter Wolters uploaded patch set 4 04/14/16, 19:31

  5. Wouter Wolters voted on patch set 4 CR +1 V +1 04/14/16, 19:32

  6. Christian Kuhn commented on patch set 4 04/14/16, 20:20

    on it.
  7. Christian Kuhn commented on patch set 4 04/14/16, 20:31

    looks good to me apart from the remarks by frank.

    GeneralUtility.php:3197

    rofl
  8. Frank Nägler commented on patch set 4 CR -1 04/14/16, 20:43

    thx for the great patch, but the two removed params have to throw a deprecation log message.

    GeneralUtility.php:1529

    this change must trigger a deprecation message

    GeneralUtility.php:3196

    this change must trigger a deprecation message

    Deprecation-75621-GeneralUtilityMethods.rst:20

    this change must trigger a deprecation message

    Deprecation-75621-GeneralUtilityMethods.rst:28

    should be a :
  9. Wouter Wolters commented on patch set 4 04/14/16, 20:46

    How do you wanna trigger that deprecation message??
  10. Christian Kuhn commented on patch set 4 04/14/16, 20:47

    GeneralUtility.php:3198

    not 100% confident with this change.

    GeneralUtility.php:4207

    this means false is given to getHostname() ... btw: why?
  11. Christian Kuhn commented on patch set 4 04/14/16, 20:48

    @wouter: initialize variable to null in method argument and throw deprecation if not not null.
  12. Nicole Hummel commented on patch set 4 04/15/16, 08:39

    GeneralUtility.php:701

    Wouldn't it make sense to have that function in VersionNumberUtility?
  13. Oliver Hader commented on patch set 4 04/15/16, 08:58

    GeneralUtility.php:1146

    We can use http://php.net/lcfirst directly, can't we?

    GeneralUtility.php:3198 Reply

    It makes sense, however the possibility to enforce using the uname here is disabled. From the point of view how that was used in the core, it looks fine for me

    GeneralUtility.php:4207 Reply

    To avoid using HTTP_HOST, what is undefined in CLI context... thus, these checks were doubled (request type and method parameter)

    Deprecation-75621-GeneralUtilityMethods.rst:20

    should be :php:`...` if using RST roles

    Deprecation-75621-GeneralUtilityMethods.rst:28

    should be :php:`...` if using RST roles

    Deprecation-75621-GeneralUtilityMethods.rst:30

    :php:
  14. Oliver Hader commented on patch set 4 CR -1 04/15/16, 09:00

    I'm on it...
  15. Oliver Hader commented on patch set 4 04/15/16, 09:07

    Deprecation-75621-GeneralUtilityMethods.rst:28 Reply

    Done

    Deprecation-75621-GeneralUtilityMethods.rst:30 Reply

    Done
  16. Oliver Hader uploaded patch set 5 04/15/16, 09:10

  17. Wouter Wolters voted on patch set 5 CR +1 V +1 04/18/16, 14:20

  18. Frank Nägler commented on patch set 5 CR -1 04/18/16, 14:24

    wrong deprecation message

    GeneralUtility.php:3205

    caling with any parameter or Paramter 1, not Parameter 2
  19. Frank Nägler commented on patch set 5 V -1 04/18/16, 14:32

    the behavior of GU::getHostname changed with this patch. calling GeneralUtility::getHostname(false) returns: before patch: vagrant.vm after patch: t3.local.typo3.org So I am not sure about this change.
  20. Benni Mack commented on patch set 5 04/18/16, 19:10

    yeah, let's do the deprecations and the breaking changes separately, using the change only for the deprecatoins IMHO.
  21. Benni Mack uploaded patch set 6 04/19/16, 16:42

  22. Benni Mack commented on patch set 4 04/19/16, 16:42

    I left the getHostname() stuff untouched for now to get the rest in
  23. Christian Kuhn voted on patch set 6 CR +1 V +1 04/19/16, 18:22

  24. Georg Ringer voted on patch set 6 CR +2 V +2 04/19/16, 19:25

  25. Gerrit merged patch set 6 04/19/16, 19:25