47879[BUGFIX] fix windows file paths in copydirectory
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Sonja Großewinkelmann +1
- Andreas Kienast +1
- Alessandro Filira +1
- Steffen Frese +1
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Elmar Hinz +1
- Jörg Bösche +1
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Susi Moog +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2425
-
Jigal van Hemert uploaded patch set 1 04/23/16, 18:39
-
Nicole Hummel commented on patch set 1 04/24/16, 14:11
My thoughts about this patch: 1) no bugfix but rather a cleanup as there isn't anything broken now 2) No need to replace slashes in filename -> we don't need the path any further -> Windows is supposed to be able to handle forward and backward slashes and even a mix of them 3) SplFileInfo implements a __toString method which returns the file path -
TYPO3com voted on patch set 1 V +1 12/04/16, 11:22 Completed build in 30m 07s on Sun, 4 Dec, 12:22 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5475
-
Jörg Bösche voted on patch set 1 CR +1 12/06/16, 07:35
-
Elmar Hinz voted on patch set 1 CR +1 05/12/17, 13:23
-
Sascha Rademacher voted on patch set 1 CR +1 08/07/17, 09:06
-
Sonja Großewinkelmann voted on patch set 1 CR +1 08/14/17, 08:19
-
Nicole Hummel commented on patch set 1 CR -1 08/14/17, 08:48
I still see no advantage in this patch. There isn't any bug that is resolved. It seems to create additional overhead instead -
Nicole Hummel commented on patch set 1 08/14/17, 08:50
GeneralUtility.php:3379Windows can handle a mix of forward and backward slashes perfectly fine. As the path isn't used any further, it is sufficient to mix both separators.GeneralUtility.php:3383SplFileInfo implements a __toString() method that returns the path and file name. Perfectly fine here. -
Benni Mack commented on patch set 1 11/24/17, 21:39
@Jigal can you give feedback on Nicole's comments? Otherwise we can abandon this change. -
Jigal van Hemert commented on patch set 1 11/26/17, 08:28
GeneralUtility.php:3379ReplyBefore I pushed this patch I tried to use this function to copy a directory with subdirectories into typo3conf/ext/ and received some errors. Debugging output showed a path with mixed directory separators. Fixing the path immediately made the copy process working. Perhaps newer versions of PHP are happy with mixed separators. It's still my opinion that we should always work with one type of separator as we cannot know that in future changes of the function that is used the path will be processed further.GeneralUtility.php:3383ReplyWe're moving to strict typing in function parameters and return values and here we should rely on PHP type juggling (= automatic conversion)? upload_copy_move() specifies that the first parameter is a string and we feed it an object... -
Tobi Kretschmann voted on patch set 1 CR +1 12/04/17, 09:58
-
Steffen Frese voted on patch set 1 CR +1 12/11/17, 09:13
-
Benni Mack commented on patch set 1 03/01/18, 21:05
couldn't we just use Symfony/Finder here? -
Jigal van Hemert commented on patch set 1 03/06/18, 14:01
> couldn't we just use Symfony/Finder here? Finder uses SplFileInfo (just like the code here) which can easily produce mixed directory separators on Windows. IMO we just have to normalize information we get from the outside world before we use it. -
Alessandro Filira voted on patch set 1 CR +1 05/12/18, 10:56
-
Susi Moog commented on patch set 1 05/12/18, 13:20
GeneralUtility.php:3379ReplyMixing them also doesn't work on my windows machine. Yes, it's perfectly fine to have either / or \ but mixing both in the same string fails (at least on PHP CGI with IIS). -
Benni Mack commented on patch set 1 09/04/18, 06:04
@Jigal how to proceed here? -
Benni Mack commented on patch set 1 V +1 CR +1 10/28/18, 11:42
Nicole, the patch fixes the mentioned behaviour by Jigal, just re-checked on the code sprint. -
Susi Moog commented on patch set 1 V +1 CR +1 10/28/18, 11:57
tested with a custom script calling copyDirectory on Windows (called from powershell)... works fine. -
Susi Moog commented on patch set 1 02/17/19, 16:02
@Nicole: Can you verify Jigals / my explanation? what is missing to get a positive vote from you? -
Nicole Hummel commented on patch set 1 CR 0 02/18/19, 10:03
As I'm not able to reproduce the error, I can't verify it. -
Andreas Kienast voted on patch set 1 CR +1 02/18/19, 10:23
-
Anja Leichsenring voted on patch set 1 V +2 CR +2 02/18/19, 21:03
-
Anja Leichsenring merged patch set 2 02/18/19, 21:03