Review TYPO3_7-6 Merged

47967[BUGFIX] Harden database select step

Jigal van Hemert CR +2 V +2 Easy +22 −3 updated 05/07/16, 09:36

Commit message

Currently this step does not do precautions, when
the selected database does not exist. Additionally the step
silently skips when the chosen database already has tables.

Although the UI currently does not allow to select a non
empty database, there are situations imaginable, where the database
is empty during generation of the input form but is filled directly
after that, or a database was empty but then got deleted, which
previously ended up with a fatal error.

This change now takes care of both cases and outputs a nice error
message accordingly.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1