48004[TASK] Streamline ext_tables/ext_localconf of system extensions
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 25
- typo3/sysext/belog/ext_localconf.php+7 −7
- typo3/sysext/compatibility7/ext_tables.php+1 −1
- typo3/sysext/core/ext_tables.php1+4 −2
- typo3/sysext/css_styled_content/Configuration/TCA/Overrides/sys_template.phpnew+5 −0
- typo3/sysext/css_styled_content/Configuration/TCA/Overrides/tt_content.php+0 −3
- typo3/sysext/css_styled_content/ext_localconf.php2+7 −7
- typo3/sysext/documentation/ext_localconf.php+7 −7
- typo3/sysext/extensionmanager/ext_localconf.php+8 −5
- typo3/sysext/filemetadata/ext_localconf.php+1 −0
- typo3/sysext/fluid/Configuration/TCA/Overrides/sys_template.phpnew+4 −0
- typo3/sysext/fluid/ext_tables.phpdeleted+0 −4
- typo3/sysext/fluid_styled_content/ext_localconf.php+7 −7
- typo3/sysext/form/Configuration/TCA/Overrides/sys_template.phprenamed+0 −0
- typo3/sysext/form/ext_localconf.php+7 −7
- typo3/sysext/frontend/ext_localconf.php+6 −6
- typo3/sysext/impexp/ext_localconf.php+1 −1
- typo3/sysext/impexp/ext_tables.php1+2 −1
- typo3/sysext/indexed_search/Configuration/TCA/Overrides/sys_template.phpnew+4 −0
- typo3/sysext/indexed_search/ext_localconf.php+4 −2
- typo3/sysext/indexed_search/ext_tables.php+0 −2
Review log 1518
-
Benni Mack uploaded patch set 1 05/03/16, 20:23
-
Wouter Wolters commented on patch set 1 05/03/16, 20:59
Reported my findings to Benni. -
Mathias Brodala commented on patch set 1 CR -1 05/04/16, 07:39
ext_localconf.php:26I actually like this approach more since it is impossible to forget to unset variables created in this scope. I'd only drop call_user_func() and directly invoke the closure. -
Christian Kuhn commented on patch set 1 05/06/16, 13:12
ext_localconf.php:26Replyyeah, closure would be fine with me. -
Benni Mack uploaded patch set 2 07/11/16, 15:17
-
TYPO3com voted on patch set 2 V -1 07/11/16, 15:25 Completed build in 08m 22s on Mon, 11 Jul, 05:25 PM Test Summary: 18442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-765
-
Benni Mack uploaded patch set 3 07/20/16, 21:02
-
TYPO3com voted on patch set 3 V +1 07/20/16, 21:07 Completed build in 04m 34s on Wed, 20 Jul, 11:07 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1209
-
Wouter Wolters voted on patch set 3 CR +1 V +1 07/21/16, 11:15
-
Michael Oehlhof voted on patch set 3 CR +1 07/21/16, 12:12
-
Andreas Kienast commented on patch set 3 07/21/16, 12:53
ext_tables.php:15Do we need an `unset($importExportActions)` at the end to avoid messing with the global scope? -
Benni Mack uploaded patch set 4 07/27/16, 07:28
-
TYPO3com voted on patch set 4 V +1 07/27/16, 07:34 Completed build in 05m 19s on Wed, 27 Jul, 09:34 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1394
-
Wouter Wolters voted on patch set 4 CR +1 V +1 07/27/16, 08:14
-
Georg Ringer voted on patch set 4 CR +2 V +2 07/27/16, 17:09
-
Gerrit merged patch set 4 07/27/16, 17:09
-
Nicole Hummel commented on patch set 5 07/27/16, 20:41
Post -1 - will do a follow upext_tables.php:43This is not needed as it is done in typo3/sysext/core/Configuration/TCA/Overrides/sys_file_storage.php to be cacheable! -
Nicole Hummel commented on patch set 5 07/27/16, 20:43
Find follow up at https://review.typo3.org/49231/