Review main Merged

48004[TASK] Streamline ext_tables/ext_localconf of system extensions

Benni Mack CR +2 V +2 Normal +88 −72 updated 07/27/16, 20:43

Commit message

Avoid $_EXTKEY, $_EXTCONF and unset variables that are used.

This is done so devs who look into the core extensions to see
how things are registered see that it's always done the same way.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 25

Review log 1518

  1. Benni Mack uploaded patch set 1 05/03/16, 20:23

  2. Wouter Wolters commented on patch set 1 05/03/16, 20:59

    Reported my findings to Benni.
  3. Mathias Brodala commented on patch set 1 CR -1 05/04/16, 07:39

    ext_localconf.php:26

    I actually like this approach more since it is impossible to forget to unset variables created in this scope. I'd only drop call_user_func() and directly invoke the closure.
  4. Christian Kuhn commented on patch set 1 05/06/16, 13:12

    ext_localconf.php:26 Reply

    yeah, closure would be fine with me.
  5. Benni Mack uploaded patch set 2 07/11/16, 15:17

  6. TYPO3com voted on patch set 2 V -1 07/11/16, 15:25 Completed build in 08m 22s on Mon, 11 Jul, 05:25 PM Test Summary: 18442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-765

  7. Benni Mack uploaded patch set 3 07/20/16, 21:02

  8. TYPO3com voted on patch set 3 V +1 07/20/16, 21:07 Completed build in 04m 34s on Wed, 20 Jul, 11:07 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1209

  9. Wouter Wolters voted on patch set 3 CR +1 V +1 07/21/16, 11:15

  10. Michael Oehlhof voted on patch set 3 CR +1 07/21/16, 12:12

  11. Andreas Kienast commented on patch set 3 07/21/16, 12:53

    ext_tables.php:15

    Do we need an `unset($importExportActions)` at the end to avoid messing with the global scope?
  12. Benni Mack uploaded patch set 4 07/27/16, 07:28

  13. TYPO3com voted on patch set 4 V +1 07/27/16, 07:34 Completed build in 05m 19s on Wed, 27 Jul, 09:34 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1394

  14. Wouter Wolters voted on patch set 4 CR +1 V +1 07/27/16, 08:14

  15. Georg Ringer voted on patch set 4 CR +2 V +2 07/27/16, 17:09

  16. Gerrit merged patch set 4 07/27/16, 17:09

  17. Nicole Hummel commented on patch set 5 07/27/16, 20:41

    Post -1 - will do a follow up

    ext_tables.php:43

    This is not needed as it is done in typo3/sysext/core/Configuration/TCA/Overrides/sys_file_storage.php to be cacheable!
  18. Nicole Hummel commented on patch set 5 07/27/16, 20:43