Review main Merged

48009[TASK] Make "No renderType definition" exception more verbose

Andreas Kienast CR +2 V +2 Easy +4 −1 updated 05/04/16, 18:13

Commit message

To make the exception message more helpful, it contains now
the table name and the field name of the bogus TCA.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Markus Klein +1

Issues 1

Files 1

Review log 13

  1. Andreas Kienast uploaded patch set 1 05/04/16, 16:22

  2. Markus Klein commented on patch set 1 CR -1 05/04/16, 16:24

    NodeFactory.php:97

    no hsc in exceptions!
  3. Andreas Kienast commented on patch set 2 05/04/16, 16:25

    Published edit on patch set 1.
  4. Markus Klein commented on patch set 3 05/04/16, 16:25

    Published edit on patch set 2.
  5. Markus Klein voted on patch set 3 CR +1 V +1 05/04/16, 16:25

  6. Mathias Brodala commented on patch set 3 CR -1 05/04/16, 16:29

    Let me comment first. :-)
  7. Mathias Brodala commented on patch set 4 05/04/16, 16:30

    Published edit on patch set 3.
  8. Markus Klein voted on patch set 4 CR +1 V +1 05/04/16, 16:39

  9. Wouter Wolters voted on patch set 4 CR +1 05/04/16, 16:40

  10. Daniel Goerz voted on patch set 4 CR +1 V +1 05/04/16, 16:46

  11. Wouter Wolters voted on patch set 4 CR +2 V +2 05/04/16, 18:13

  12. Gerrit merged patch set 4 05/04/16, 18:13

  13. Wouter Wolters commented on patch set 5 05/04/16, 18:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 881649d34010d39ebd704eabae8a6191a0fb642a