Review main Abandoned

48037[TASK] Make $lastConditionTrue a local variable in TypoScriptParser

Elmar Hinz CR 0 V 0 Easy +5 −12 updated 05/09/16, 07:54

Commit message

The variable is only used locally within the function
TypoScriptParser::parse(), neither by other functions nor by recursion.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 5

  1. Elmar Hinz uploaded patch set 1 05/08/16, 21:05

  2. Elmar Hinz uploaded patch set 2 05/08/16, 21:21

  3. Elmar Hinz updated the commit message in patch set 3 05/08/16, 21:26

  4. Elmar Hinz commented on patch set 3 CR -1 05/08/16, 23:35

    It is not just a locale variable. The parse function is called multiple times on the same instance, to parse different parts of the TS. There may be rare cases, when a condition spans multiple input parts.
  5. Elmar Hinz abandoned the change 05/09/16, 07:54