Review main Abandoned

48038[WIP][TASK] Improve wording of the condition loop of TypoScriptParser

Elmar Hinz CR 0 V 0 Easy +35 −10 updated 05/28/16, 05:27

Commit message

WIP annotation:

Georg Ringer suggest to set the renamed variable to protected in the
same step. Encapsulation. Hurray!

It seems this request made this ticket to complex in number targets
to get it reviewed.

I postpone this ticket now and do the full encapsulation of the class
first. Thereafter this ticket becomes more clear in the target.

1.) The sourcecode comments that describe the scope are improved.

2.) The boolean settings follow the phrasing:

    "The [ELSE] branch is selected, if the previous condition failed."

3.) The boolean values true and false are used to set the variable.

4.) The property becomes protected.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2