Review main Merged

48060[FEATURE] Refactor category tree to SVG

Tymoteusz Motylewski CR +2 V +2 Expert +1436 −408 updated 11/21/19, 16:00

Commit message

Replace ExtJS category tree implementation with SVG based one.

Current approach reuses as much of the category logic as possible
(e.g. ExtJsJsonTreeRenderer)

The SVG tree js component is added as requirejs module.
Standalone version of the js component lives here:
https://github.com/wmdbsystems/TYPO3.Tree

Done:
- virtual scrolling (we render only the number of nodes
  which fits the current viewport) so there are minor workarounds in place
- displaying of the category tree in category record (including checked checkbox)
- a new ajax controller is added which returns full tree as json
- icons are displayed
- searching/filtering through tree
- collapse all and expand all buttons
- toolbar (search, expand all, collapse all)
- indeterminate state for checkboxes (parent is marked if child is selected)
- selection saving in the record
- maxItems handling
- new svgTree is used in all records (pages, tt_content, categories, ...)
- TCA settings: 'expandAll', 'showHeader', 'size', 'maxLevels'
  'nonSelectableLevels', 'requestUpdate', 'exclusiveKeys'
- toolbar tooltips and input placehoder
- replace collapse-all and expand-all icons with new ones from T3.icons
- remove extjs JS file (tree.js)
- readonly mode (it's possible to navigate the tree (scroll,collapse,expand,etc),
 before it was not possible)
- marking record “red” if validation fails
- icon overlay handling (for e.g. disabled categories)
- tooltip with category id

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 24

Show 4 more files