Review main Merged

48306[TASK] Update the comment of stdWrap_char to include ASCII limitation

Elmar Hinz CR +2 V +2 Easy +4 −1 updated 05/27/16, 09:31

Commit message

The PHP char() function only works reliably with ASCII codes
independent of the actual char set.

See http://php.net/manual/en/function.chr.php

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 5

  1. Elmar Hinz uploaded patch set 1 05/27/16, 07:19

  2. Morton Jonuschat uploaded patch set 2 05/27/16, 09:29

  3. Morton Jonuschat voted on patch set 2 CR +1 V +1 05/27/16, 09:29

  4. Wouter Wolters voted on patch set 2 CR +2 V +2 05/27/16, 09:31

  5. Gerrit merged patch set 2 05/27/16, 09:31