Review main Merged

48310[BUGFIX] Doctrine: Use compatible charset name for database connection

Morton Jonuschat CR +2 V +2 Easy +34 −4 updated 05/27/16, 12:26

Commit message

Use the charset name 'utf8' instead of 'utf-8' for MySQL connections as
some MySQL server versions silently ignore the connection charset name
'utf-8' and work with the global default connection charset instead.
Using 'utf8' as charset name doesn't exhibit this behavior.

Also changes the silent upgrade wizard to only set the default driver
and connection charset if no value has been configured, this avoids
silently changing non-default values for these options.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1