Review main Abandoned

48326[FEATURE] Allow arrays as callables in callUserFunctions

Benni Mack CR 0 V 0 Easy +43 −3 updated 07/20/16, 22:17

Commit message

- Unit Tests missing.
- RST missing
- Ticket # missing

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 7

  1. Benni Mack uploaded patch set 1 05/27/16, 11:22

  2. Andreas Kienast commented on patch set 1 05/27/16, 11:29

    GeneralUtility.php:3716

    ===

    GeneralUtility.php:3717

    A blast from the past? ;)

    GeneralUtility.php:3727

    ===
  3. Morton Jonuschat commented on patch set 1 05/27/16, 11:37

    GeneralUtility.php:3717 Reply

    Same exception as line 3796 :)
  4. Helmut Hummel commented on patch set 1 05/27/16, 12:29

    GeneralUtility.php:3710

    is there a reason to not just check with is_callable($funcName)?
  5. Benni Mack commented on patch set 1 05/27/16, 13:40

    GeneralUtility.php:3710 Reply

    hmm, this would validate pure PHP functions as well (which is usually not a problem) but then we'd need to do the array thingy in another step. The main idea is this, this feature (having arrays) could allow us to deprecate the old -> syntax in a few versions (once we migrated all places to that syntax).
  6. Benni Mack uploaded patch set 2 05/27/16, 13:43

  7. Benni Mack abandoned the change 07/20/16, 22:17