Review main Merged

48375[BUGFIX] Correct type for constants linkWrap height and width

Wouter Wolters CR +2 V +2 Easy +3 −3 updated 05/29/16, 08:11

Commit message

The height and width have a default value with a "m" in it.
This is stripped of because the wrong data type is used. Use string
instead to circumvent the automatic stripping of the letter "m".

Review

  • Code review CR +2
    • Markus Klein +2
    • Michael Oehlhof +1
    • Oliver Hader +1
  • Verified V +2
    • Markus Klein +2
    • Oliver Hader +1

Issues 1

Files 2

Review log 11

  1. Wouter Wolters uploaded patch set 1 05/28/16, 19:36

  2. Wouter Wolters updated the commit message in patch set 2 05/28/16, 19:38

  3. Markus Klein voted on patch set 2 CR +1 V +1 05/28/16, 19:43

  4. Oliver Hader voted on patch set 2 CR +1 05/28/16, 20:20

  5. Oliver Hader uploaded patch set 3 05/28/16, 20:40

  6. Oliver Hader voted on patch set 3 CR +1 V +1 05/28/16, 20:40

  7. Riccardo De Contardi commented on patch set 3 05/28/16, 20:57

    Maybe also styles.content.textmedia.maxW styles.content.textmedia.maxWInText should be string instead of int+ ? Or is it a matter for a different issue?
  8. Michael Oehlhof voted on patch set 3 CR +1 05/28/16, 22:50

  9. Markus Klein commented on patch set 3 CR +2 V +2 05/29/16, 08:11

    No Riccardo, these candidates are used in calculations, so there is no cropping modifier support.
  10. Gerrit merged patch set 3 05/29/16, 08:11

  11. Markus Klein commented on patch set 4 05/29/16, 08:11

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 8f718b02c5342cba24a48af8f80147490515e8b7