Review main Merged

48674[TASK] Update mso/idna-convert to 1.1.0

Wouter Wolters CR +2 V +2 Normal +75 −16 updated 07/06/16, 08:18

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1320

  1. Wouter Wolters uploaded patch set 1 06/24/16, 15:02

  2. TYPO3com voted on patch set 1 V -1 06/24/16, 15:08 Completed build in 06m 30s on Fri, 24 Jun, 05:08 PM Test Summary: 32 of 9256 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-182

  3. Wouter Wolters uploaded patch set 2 06/24/16, 15:17

  4. TYPO3com voted on patch set 2 V -1 06/24/16, 15:22 Completed build in 04m 44s on Fri, 24 Jun, 05:22 PM Test Summary: 9168 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-183

  5. Wouter Wolters commented on patch set 2 06/24/16, 16:58

  6. TYPO3com commented on patch set 1 06/24/16, 17:56 Completed build in 3h 00m 42s on Fri, 24 Jun, 07:56 PM Test Summary: 32 of 9394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-182

  7. TYPO3com voted on patch set 2 V +1 06/24/16, 17:56 Completed build in 2h 43m 18s on Fri, 24 Jun, 07:56 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-183

  8. Christian Kuhn commented on patch set 2 06/27/16, 14:08

    GeneralUtility.php:1075

    i think it would be a good idea to have a single simple basic unit test. this would verify the IdnaConvert class is correctly called and a proper result is returned. We don't need to have detailled tests with all bells and whistles, just a simple one that shows the call chain does work.
  9. Wouter Wolters commented on patch set 2 06/27/16, 14:19

    These tests are already there. I had failing tests when I upgraded the idna converter.
  10. Wouter Wolters uploaded patch set 3 06/29/16, 17:44

  11. TYPO3com voted on patch set 3 V +1 06/29/16, 17:47 Completed build in 03m 26s on Wed, 29 Jun, 07:47 PM Test Summary: 9626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-315

  12. Wouter Wolters updated the commit message in patch set 4 06/30/16, 11:48

  13. TYPO3com voted on patch set 4 V +1 06/30/16, 11:54 Completed build in 05m 34s on Thu, 30 Jun, 01:54 PM Test Summary: 9644 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-346

  14. Jörg Bösche uploaded patch set 5 07/03/16, 17:47

  15. TYPO3com voted on patch set 5 V +1 07/03/16, 17:50 Completed build in 02m 48s on Sun, 3 Jul, 07:50 PM Test Summary: 9655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-408

  16. Jörg Bösche commented on patch set 5 07/03/16, 17:51

    Added a unit test for the GeneralUtility::idnaEncode() method. Even if there are tests for this, they are not explicitly for this method. The data provider is based on the German Wikipedia documentation and its examples. https://de.wikipedia.org/wiki/Internationalisierter_Domainname#Beispiel-Domains
  17. Christian Kuhn commented on patch set 5 CR +1 V +1 07/05/16, 22:13

    thank you two :)
  18. Susi Moog voted on patch set 5 CR +1 V +1 07/06/16, 07:09

  19. Christian Kuhn voted on patch set 5 CR +2 V +2 07/06/16, 08:18

  20. Gerrit merged patch set 5 07/06/16, 08:18