48698[TASK] Change array() to new short form [] in ContentObjectRenderer
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1820
-
Elmar Hinz uploaded patch set 1 06/27/16, 18:26
-
TYPO3com voted on patch set 1 V +1 06/27/16, 18:29 Completed build in 02m 37s on Mon, 27 Jun, 08:29 PM Test Summary: 9611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-272
-
Michael Oehlhof voted on patch set 1 CR +1 V +1 06/27/16, 18:41
-
Wouter Wolters commented on patch set 1 CR -1 06/27/16, 19:46
I'm not a fan of such changes. This makes backporting patches to the 7.6 branch really hard. We better do such code changes in late 8 development. -
Elmar Hinz commented on patch set 1 06/27/16, 19:55
No problem to postpone it. -
Jörg Bösche commented on patch set 1 CR +1 V +1 06/27/16, 21:07
Yes, we should implement the change in version 8.x (branch: master). Looks good. Test run for the class (php) and suite (xml) is green. -
Wouter Wolters commented on patch set 1 CR -2 06/28/16, 17:42
I put a -2 on this one to prevent merging this now already. When we are near 8LTS we can IMO merge this patch and maybe switch the complete core to short array syntax. -
Elmar Hinz commented on patch set 1 06/28/16, 19:13
I worked out a vim macro, that does the replacement almost automatically. Unfortunately it can't differ the comment context. Still each replacement needs a manual confirmation. -
Wouter Wolters commented on patch set 1 06/28/16, 21:01
We can do this with the php-cs-fixer as well. -
Oliver Klee voted on patch set 1 CR +1 06/29/16, 12:58
-
Elmar Hinz abandoned the change 07/07/16, 07:37
Do it with the new php-cd-fixer tools later for the whole core. -
Wouter Wolters restored the change 07/07/16, 18:54
Discussed in the core, we can do this one now. -
Wouter Wolters commented on patch set 1 CR 0 07/07/16, 18:55
*core team* -
Wouter Wolters uploaded patch set 2 07/07/16, 18:57
-
Wouter Wolters voted on patch set 2 CR +1 V +1 07/07/16, 18:58
-
TYPO3com voted on patch set 2 V +1 07/07/16, 19:02 Completed build in 04m 34s on Thu, 7 Jul, 09:02 PM Test Summary: 18398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-594
-
Oliver Klee voted on patch set 2 CR +1 07/07/16, 19:45
-
Christian Kuhn commented on patch set 2 CR +1 V +1 07/07/16, 20:45
Rationale: In general we don't want to fully switch master to short array syntax now since this will significantly increase issues when back porting stuff to 7.6. Thus, we will rather wait with a full roll out until short before v8 LTS release. But, for areas that are under heavy refactoring like this class where we expect bigger changes in the near future, it is ok if we do the array transition beforehand. So: +1 for this patch, but no general roll out in the whole core right now. -
Christian Kuhn voted on patch set 2 CR +2 V +2 07/08/16, 15:49
-
Gerrit merged patch set 2 07/08/16, 15:49