Review TYPO3_7-6 Merged

48812[BUGFIX] Adodb: PHP 7.1 compatibility

Frank Nägler CR +2 V +2 Easy +0 −4 updated 07/05/16, 20:33

Commit message

unset($this) throws a fatal if linting with PHP 7.1.
According to php.net/unset the construct isn't allowed since
PHP 5. Now the linter stumbles upon that, too.
Solution is to drop these calls, the according files and
classes from adodb are not used by our dbal integration anyway.
A pull request to upstream is pending for this, too, but we
never know when it will be merged. Should be safe to do that
locally in our adapted version.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2