Review main Merged

48833[TASK] Script to CGL check latest core commit

Christian Kuhn CR +2 V +2 Normal +46 −16 updated 07/06/16, 19:59

Commit message

A script is added to CGL check latest core commit with
php-cs-fixer. This can be used by commiters before pushing
patches to gerrit to verify CGL compatibility. The bamboo
build chain will later use the same script on each pre-merge
run.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 5

Review log 1525

  1. Christian Kuhn uploaded patch set 1 07/06/16, 18:50

  2. TYPO3com voted on patch set 1 V +1 07/06/16, 18:53 Completed build in 02m 54s on Wed, 6 Jul, 08:53 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-522

  3. Christian Kuhn uploaded patch set 2 07/06/16, 19:11

  4. Christian Kuhn uploaded patch set 3 07/06/16, 19:13

  5. TYPO3com voted on patch set 2 V +1 07/06/16, 19:14 Completed build in 03m 20s on Wed, 6 Jul, 09:14 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-523

  6. TYPO3com voted on patch set 3 V +1 07/06/16, 19:17 Completed build in 03m 32s on Wed, 6 Jul, 09:17 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-524

  7. Christian Kuhn uploaded patch set 4 07/06/16, 19:22

  8. Christian Kuhn uploaded patch set 5 07/06/16, 19:23

  9. TYPO3com voted on patch set 4 V +1 07/06/16, 19:25 Completed build in 03m 25s on Wed, 6 Jul, 09:25 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-525

  10. Christian Kuhn uploaded patch set 6 07/06/16, 19:26

  11. Christian Kuhn commented on patch set 6 CR +1 V +1 07/06/16, 19:28

    works: red with a run from patch set 5 that had a cgl issue: https://bamboo.typo3.com/browse/CORE-TL-73 green with patch set 6: https://bamboo.typo3.com/browse/CORE-TL-72
  12. TYPO3com voted on patch set 5 V +1 07/06/16, 19:28 Completed build in 04m 34s on Wed, 6 Jul, 09:28 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-526

  13. TYPO3com voted on patch set 6 V +1 07/06/16, 19:30 Completed build in 04m 30s on Wed, 6 Jul, 09:30 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-527

  14. Christian Kuhn commented on patch set 6 CR -1 V 0 07/06/16, 19:35

    wouter has another idea, let's wait for him.
  15. Wouter Wolters uploaded patch set 7 07/06/16, 19:46

  16. Wouter Wolters uploaded patch set 8 07/06/16, 19:48

  17. TYPO3com voted on patch set 7 V +1 07/06/16, 19:50 Completed build in 03m 47s on Wed, 6 Jul, 09:50 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-530

  18. Christian Kuhn uploaded patch set 9 07/06/16, 19:51

  19. Christian Kuhn uploaded patch set 10 07/06/16, 19:52

  20. Christian Kuhn voted on patch set 10 CR +1 V +1 07/06/16, 19:52

  21. TYPO3com voted on patch set 8 V +1 07/06/16, 19:53 Completed build in 04m 24s on Wed, 6 Jul, 09:53 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-531

  22. TYPO3com voted on patch set 9 V +1 07/06/16, 19:56 Completed build in 04m 23s on Wed, 6 Jul, 09:56 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-532

  23. Wouter Wolters voted on patch set 10 CR +2 V +2 07/06/16, 19:56

  24. Gerrit merged patch set 10 07/06/16, 19:56

  25. TYPO3com commented on patch set 10 07/06/16, 19:59 Completed build in 06m 28s on Wed, 6 Jul, 09:59 PM Test Summary: 9666 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-533