Review main Merged

48907[TASK] Move arguments to initializeArguments() in CropVH in ext:fluid

Roberto Torresani CR +2 V +2 Normal +80 −29 updated 07/11/16, 19:51

Commit message

Move the argument registrations away from the render() method
to initializeArguments(), to prevent any errors with PHP7 and
subclassed ViewHelpers if/when render() method signatures change
Change the UnitTest CropViewHelperTest with setArguments()
Introduce the function setArgumentsUnderTest()

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2