Review main Merged

48926[TASK] Move arguments to initializeArguments() in UrlencodeVH in ext:fluid

Roberto Torresani CR +2 V +2 Normal +50 −28 updated 07/15/16, 18:11

Commit message

Move the argument registrations away from the render() method
to initializeArguments(), to prevent any errors with PHP7 and
subclassed ViewHelpers if/when render() method signatures change.
Change the UnitTest UrlencodeViewHelperTest with setArguments()
Remove test renderReturnsUnmodifiedSourceIfItIsNoString() because
pass a class but is expected a string

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2