Review main Merged

49134[TASK] Use CacheManager within TemplateService

Benni Mack CR +2 V +2 Normal +38 −13 updated 07/27/16, 08:38

Commit message

In order to decouple TemplateService and PageRepository more
and more, the Cache Management for TS templates are moved
into proper (and properly named) protected methods.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Frederic Gaus +1
    • Sascha Egerer +1
  • Verified V +2
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Benni Mack uploaded patch set 1 07/20/16, 15:03

  2. TYPO3com voted on patch set 1 V -1 07/20/16, 15:09 Completed build in 06m 03s on Wed, 20 Jul, 05:09 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1195

  3. Benni Mack uploaded patch set 2 07/20/16, 20:19

  4. TYPO3com voted on patch set 2 V +1 07/20/16, 20:24 Completed build in 04m 57s on Wed, 20 Jul, 10:24 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1203

  5. Georg Ringer voted on patch set 2 CR +1 V +1 07/21/16, 16:08

  6. Sascha Egerer commented on patch set 2 CR -1 07/21/16, 19:47

    TemplateService.php:450

    That must be `$cacheIdentifier`
  7. Benni Mack commented on patch set 3 07/25/16, 06:05

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 07/25/16, 06:17 Completed build in 11m 00s on Mon, 25 Jul, 08:17 AM Test Summary: 19374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1344

  9. Frederic Gaus voted on patch set 3 CR +1 07/25/16, 08:54

  10. Sascha Egerer voted on patch set 3 CR +1 07/27/16, 08:01

  11. Georg Ringer voted on patch set 3 CR +2 V +2 07/27/16, 08:38

  12. Gerrit merged patch set 3 07/27/16, 08:38