Review main Merged Breaking

49202[!!!][FEATURE] Make BE favicon configurable via Extension manager

Georg Ringer CR +2 V +2 Normal +76 −1 updated 08/23/16, 19:54

Commit message

Make the path to the favicon configurable in the Extension Manager instead
of the TBE_STYLES.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1623

  1. Georg Ringer uploaded patch set 1 07/26/16, 08:20

  2. TYPO3com voted on patch set 1 V -1 07/26/16, 08:25 Completed build in 04m 41s on Tue, 26 Jul, 10:25 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1368

  3. Georg Ringer uploaded patch set 2 08/11/16, 11:33

  4. TYPO3com voted on patch set 2 V -1 08/11/16, 11:37 Completed build in 03m 51s on Thu, 11 Aug, 01:37 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1992

  5. Georg Ringer uploaded patch set 3 08/11/16, 11:54

  6. TYPO3com voted on patch set 3 V +1 08/11/16, 11:58 Completed build in 04m 01s on Thu, 11 Aug, 01:58 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1993

  7. Christian Kuhn commented on patch set 3 CR -1 08/11/16, 20:37

    tmpMlhBeo:1

    whats that?

    PathUtility.php:274

    please let benni have a look at that. i guess he will not be too happy if we add a path / uri related method - maybe he has an idea for a better solution since he's doing so much path cleanups lately.
  8. Benni Mack commented on patch set 3 08/12/16, 05:54

    PathUtility.php:274 Reply

    yeah, doesn't PathUtility::getAbsoluteWebPath() solve the problem for you directly, Georg? because that's what it should do directly.
  9. Georg Ringer commented on patch set 3 08/16/16, 05:42

    PathUtility.php:274 Reply

    no this creates from "fileadmin/favicon.ico" => "/typo3/fileadmin/favicon.ico" which is then of course not valid. i copied the method from previous usage
  10. Georg Ringer uploaded patch set 4 08/16/16, 05:42

  11. TYPO3com voted on patch set 4 V +1 08/16/16, 05:46 Completed build in 03m 34s on Tue, 16 Aug, 07:46 AM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2078

  12. Georg Ringer uploaded patch set 5 08/16/16, 06:30

  13. TYPO3com voted on patch set 5 V +1 08/16/16, 06:33 Completed build in 02m 49s on Tue, 16 Aug, 08:33 AM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2079

  14. Benni Mack voted on patch set 5 CR +1 08/23/16, 07:53

  15. Mathias Brodala commented on patch set 6 08/23/16, 08:11

    Published edit on patch set 5.
  16. TYPO3com voted on patch set 6 V +1 08/23/16, 08:15 Completed build in 03m 41s on Tue, 23 Aug, 10:15 AM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2239

  17. Benni Mack voted on patch set 6 CR +1 08/23/16, 10:11

  18. Benni Mack voted on patch set 6 V +1 08/23/16, 19:12

  19. Christian Kuhn uploaded patch set 7 08/23/16, 19:31

  20. Christian Kuhn voted on patch set 7 CR +1 V +1 08/23/16, 19:32

  21. TYPO3com voted on patch set 7 V +1 08/23/16, 19:35 Completed build in 03m 38s on Tue, 23 Aug, 09:35 PM Test Summary: 18644 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2279

  22. Benni Mack voted on patch set 7 CR +2 V +2 08/23/16, 19:54

  23. Gerrit merged patch set 7 08/23/16, 19:54