Review main Merged

49214[BUGFIX] Set $escapeOutput to false for various backend VH

Georg Ringer CR +2 V +2 Easy +16 −0 updated 07/27/16, 14:20

Commit message

Set $escapeOutput to false for the following ViewHelpers:

- PagePathViewHelper
- PageInfoViewHelper

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Georg Ringer uploaded patch set 1 07/26/16, 17:08

  2. TYPO3com voted on patch set 1 V +1 07/26/16, 17:18 Completed build in 09m 47s on Tue, 26 Jul, 07:18 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1390

  3. Helmut Hummel voted on patch set 1 CR +1 07/26/16, 17:36

  4. Helmut Hummel commented on patch set 1 07/26/16, 17:37

    PageInfoViewHelper.php:42

    we added a reason in the description in all other view helpers. In this case: "This view helper renders HTML, thus output must not be escaped"
  5. Georg Ringer uploaded patch set 2 07/26/16, 17:48

  6. TYPO3com voted on patch set 2 V +1 07/26/16, 17:56 Completed build in 08m 01s on Tue, 26 Jul, 07:56 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1391

  7. Wouter Wolters voted on patch set 2 CR +1 V +1 07/27/16, 08:15

  8. Helmut Hummel voted on patch set 2 CR +2 07/27/16, 08:56

  9. Benni Mack voted on patch set 2 CR +2 V +2 07/27/16, 14:20

  10. Gerrit merged patch set 2 07/27/16, 14:20