Review main Merged

49231[FOLLOWUP][TASK] Streamline ext_tables/ext_localconf of system extensions

Nicole Hummel CR +2 V +2 Easy +0 −4 updated 07/28/16, 06:37

Commit message

This patch removes a superfluous DriverRegistry->addDriversToTCA call
which is done in Configuration/TCA/Overrides/sys_file_storage.php
already.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Nicole Hummel uploaded patch set 1 07/27/16, 20:43

  2. TYPO3com voted on patch set 1 V +1 07/27/16, 20:47 Completed build in 04m 02s on Wed, 27 Jul, 10:47 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1411

  3. Christian Kuhn commented on patch set 1 CR +1 07/27/16, 22:06

    thx. wondered about this very line, too. benni, any special reason that came in with https://review.typo3.org/#/c/48004/5/typo3/sysext/core/ext_tables.php or could you verify this patch? verified on reading, but i didn't had a deeper look or too many thoughts on this, don't rate my vote too high.
  4. Benni Mack commented on patch set 1 CR +2 07/28/16, 06:05

    Sure, I know why :) The original patch was made before https://review.typo3.org/#/c/48047/ was made and got in between. When I rebased the change was kept in, thus resulting in the wrong code. So, it wasn't on purpose and nicole got it just right! Thanks for the fast followup
  5. Benni Mack commented on patch set 1 V +1 07/28/16, 06:29

    Thanks again for finding that one!
  6. Wouter Wolters voted on patch set 1 CR +2 V +2 07/28/16, 06:37

  7. Gerrit merged patch set 1 07/28/16, 06:37